Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local volume dialog default size #3007

Merged
merged 1 commit into from Apr 8, 2017

Conversation

@Kissaki
Copy link
Member

Kissaki commented Apr 8, 2017

The default geometry was too small on macOS (#2993).

Remove default geometry and instead specify a minimum width. The dialog
will auto-adjust its height for content.

Fixes #2993


As I don't have a macOS, untested.

The default geometry was too small on macOS (#2993).

Remove default geometry and instead specify a minimum width. The dialog
will auto-adjust its height for content.

Fixes #2993
@Kissaki Kissaki added the ui label Apr 8, 2017
@Kissaki Kissaki requested a review from mkrautz Apr 8, 2017
@mkrautz mkrautz self-assigned this Apr 8, 2017
@mkrautz
mkrautz approved these changes Apr 8, 2017
Copy link
Member

mkrautz left a comment

Tested. Works.

LGTM.

@mkrautz mkrautz merged commit db4a591 into mumble-voip:master Apr 8, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kissaki Kissaki deleted the Kissaki:fix-localvolume-dialogsize branch Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.