New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide OS information from server ("privacy mode") #3009

Merged
merged 1 commit into from Apr 9, 2017

Conversation

Projects
None yet
2 participants
@Piratonym
Contributor

Piratonym commented Apr 8, 2017

This patch adds an option to not send information about the user's OS and OS version to the server. It implements the request from #2899.

The Mumble version and release is still sent, since the server seems to use it for certain decisions. This information alone should not reveal much information about the user.

The option is currently placed in the "Misc" section of the "Network" tab.

@mkrautz

I have a few minor changes I would like to have made.

Looks very good though.

Show outdated Hide outdated src/mumble/Settings.cpp
Show outdated Hide outdated src/mumble/Settings.cpp
Show outdated Hide outdated src/mumble/Settings.h
Show outdated Hide outdated src/mumble/NetworkConfig.ui
Show outdated Hide outdated src/mumble/NetworkConfig.ui
@Piratonym

This comment has been minimized.

Show comment
Hide comment
@Piratonym

Piratonym Apr 9, 2017

Contributor

Squashed the changes.

Concerning other places with OS information: It seems to be sent by the crash reporter (only after the user agrees, CrashReporter.cpp:183) and as part of the User-Agent header in HTTP requests (NetworkConfig.cpp:161). RFC 7231 does not require the OS information (see section 5.5.3), so removing it there should not cause any problems.

Contributor

Piratonym commented Apr 9, 2017

Squashed the changes.

Concerning other places with OS information: It seems to be sent by the crash reporter (only after the user agrees, CrashReporter.cpp:183) and as part of the User-Agent header in HTTP requests (NetworkConfig.cpp:161). RFC 7231 does not require the OS information (see section 5.5.3), so removing it there should not cause any problems.

@mkrautz

LGTM except this small typo.

Show outdated Hide outdated src/mumble/Settings.cpp
Show outdated Hide outdated src/mumble/Settings.cpp
@Piratonym

This comment has been minimized.

Show comment
Hide comment
@Piratonym

Piratonym Apr 9, 2017

Contributor

Thanks, corrected.

Contributor

Piratonym commented Apr 9, 2017

Thanks, corrected.

@mkrautz

This comment has been minimized.

Show comment
Hide comment
@mkrautz

mkrautz Apr 9, 2017

Member

Concerning other places with OS information: It seems to be sent by the crash reporter (only after the user agrees, CrashReporter.cpp:183) and as part of the User-Agent header in HTTP requests (NetworkConfig.cpp:161). RFC 7231 does not require the OS information (see section 5.5.3), so removing it there should not cause any problems.

OK, feel free to address that in a separate PR. Thanks!

Member

mkrautz commented Apr 9, 2017

Concerning other places with OS information: It seems to be sent by the crash reporter (only after the user agrees, CrashReporter.cpp:183) and as part of the User-Agent header in HTTP requests (NetworkConfig.cpp:161). RFC 7231 does not require the OS information (see section 5.5.3), so removing it there should not cause any problems.

OK, feel free to address that in a separate PR. Thanks!

@mkrautz

mkrautz approved these changes Apr 9, 2017

@mkrautz mkrautz merged commit 65909b8 into mumble-voip:master Apr 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Piratonym Piratonym deleted the Piratonym:feature-hideos branch Apr 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment