Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include OS in HTTP user agent depending on privacy setting #3015

Merged
merged 1 commit into from Apr 14, 2017

Conversation

@Piratonym
Copy link
Contributor

@Piratonym Piratonym commented Apr 9, 2017

This is a followup to #3009 (and #2899). Currently, information about the user's operating system is sent regardless of the privacy setting

  • by the crash reporter and
  • in the HTTP User-Agent header field.

IMO, crash reports should contain this information. They are also not sent without the user's approval.

This patch changes the HTTP user agent to not include the user's OS if the privacy setting is enabled and changes the setting's description.

RFC 7231 does not mandate the OS to be included in the user agent, see section 5.5.3.

@Piratonym Piratonym mentioned this pull request Apr 9, 2017
</property>
<property name="text">
<string>Do not send OS information to Mumble servers</string>
<string>Do not send OS information to Mumble and web servers</string>
Copy link
Member

@mkrautz mkrautz Apr 10, 2017

I think we should be more clear here. Sorry if this is annoying.

In "Do not send OS information to Mumble and web servers", the "to Mumble" part could be interpreted as "to the Mumble project" (or, to people not familiar with Mumble or community-based FOSS projects, "the company behind Mumble").

The straight-forward way to fix it would be:

Do not send OS information to Mumble servers or web servers.

It can definitely fit in the ConfigDialog, even though the string is a bit on the long side.

Maybe we could change it to "Do not send OS information", and explain it in the tooltip?

Copy link
Contributor Author

@Piratonym Piratonym Apr 12, 2017

No problem, I can change it. Also, feel free to just push changes like this to the branch, you (and all other Mumble maintainers) should be able to do so.

</property>
<property name="text">
<string>Do not send OS information to Mumble servers</string>
<string>Do not send OS information to Mumble and web servers</string>
Copy link
Member

@mkrautz mkrautz Apr 10, 2017

Other than this, LGTM.

@mkrautz mkrautz merged commit 4e430f7 into mumble-voip:master Apr 14, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants