New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include OS in HTTP user agent depending on privacy setting #3015

Merged
merged 1 commit into from Apr 14, 2017

Conversation

Projects
None yet
2 participants
@Piratonym
Contributor

Piratonym commented Apr 9, 2017

This is a followup to #3009 (and #2899). Currently, information about the user's operating system is sent regardless of the privacy setting

  • by the crash reporter and
  • in the HTTP User-Agent header field.

IMO, crash reports should contain this information. They are also not sent without the user's approval.

This patch changes the HTTP user agent to not include the user's OS if the privacy setting is enabled and changes the setting's description.

RFC 7231 does not mandate the OS to be included in the user agent, see section 5.5.3.

@Piratonym Piratonym referenced this pull request Apr 9, 2017

Closed

Add "privacy mode" #2899

Show outdated Hide outdated src/mumble/NetworkConfig.ui Outdated
Show outdated Hide outdated src/mumble/NetworkConfig.ui Outdated

@mkrautz mkrautz merged commit 4e430f7 into mumble-voip:master Apr 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment