Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BF2142 plugin, adding identity support #3040

Merged
merged 1 commit into from Apr 18, 2017

Conversation

@Flumble
Copy link
Contributor

@Flumble Flumble commented Apr 18, 2017

The avatar orientation is copied from the camera orientation for lack of something better.

In addition to the BF2 identity fields, it includes

  • ipport to avoid having to parse the context on the server
  • name for the in-game player name
  • on_voip and on_voip_com to e.g. mimick the ingame voip behaviour or address different groups of players
  • target_squad_id to e.g. address a single squad as commander
updates to BF2142 final patch v1.51 (compatible with Revive)
avatar orientation is copied from camera orientation
@davidebeatrici
Copy link
Member

@davidebeatrici davidebeatrici commented Apr 18, 2017

Thank you very much for your contribution!
Once the checks are passed, I will merge the PR and update the Wiki page.

Context based on host IP address and port. Identity: Host IP address and port, Team, Squad ID, Commander, Squad Leader, Target squad ID, On VoIP, On VoIP com, Player

Is it OK for you?

What do the on_voip and on_voip_com variables represent, exactly?

@davidebeatrici davidebeatrici merged commit a935808 into mumble-voip:master Apr 18, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Flumble
Copy link
Contributor Author

@Flumble Flumble commented Apr 18, 2017

That'd be great :)

The on_voip_com flag corresponds to holding down the "com channel" push-to-talk key (default B) of the built-in voip. If I understand correctly, it allows the commander to talk to all squad leaders and allows squad leaders to talk to the commander.
The on_voip flag corresponds to holding down any push-to-talk key (default V and B), where V allows squad members and their leader to talk to each other.

(I think reusing the "com channel" key is the best way to talk to the commander because of its visual indicator in the game and having a graceful fallback when the commander is not on the mumble server. I'm not sure whether on_voip has any added value, though.)

@davidebeatrici
Copy link
Member

@davidebeatrici davidebeatrici commented Apr 19, 2017

Thank you for the excellent explanation. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.