Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add itch.exe as known overlay launcher #3046

Merged
merged 1 commit into from Apr 23, 2017

Conversation

@Kissaki
Copy link
Member

@Kissaki Kissaki commented Apr 23, 2017

See #3043, fix if the itch user does not use the sandboxing feature of
the itch launcher.

See #3043, fix if the itch user does not use the sandboxing feature of
the itch launcher.
@Kissaki Kissaki added the overlay label Apr 23, 2017
@Kissaki Kissaki requested a review from mkrautz Apr 23, 2017
@mkrautz
Copy link
Member

@mkrautz mkrautz commented Apr 23, 2017

Maybe add isolate.exe as well? From ProcExp, that was the parent of the sandboxed processes. Or do you think it's unnecessary since it doesn't work at the moment?

@Kissaki
Copy link
Member Author

@Kissaki Kissaki commented Apr 23, 2017

I don't really like that isolate.exe is such a generic name either… :)

Do launchers have to be direct parents?

@Kissaki
Copy link
Member Author

@Kissaki Kissaki commented Apr 23, 2017

GetProcessAncestorChain searches parents recursively. So isolate shouldn't be necessary, if we can find itch. So I'm for leaving isolate.exe out.

@mkrautz
Copy link
Member

@mkrautz mkrautz commented Apr 23, 2017

Right, I forgot. :)

@Kissaki Kissaki merged commit 1464873 into mumble-voip:master Apr 23, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kissaki Kissaki deleted the Kissaki:olay-launcher-itch branch Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.