Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/bf2: extend identity with in-game VoiP state and selected squad #3067

Merged
merged 2 commits into from May 7, 2017

Conversation

@Flumble
Copy link
Contributor

commented May 5, 2017

(and updated peekProc call signatures)
(and changed whitespace in the comment block so it's aligned regardless of tab size)

Like #3040 did for BF2142, this adds the following fields to the BF2 identity:

  • ipport to avoid having to parse the context on the server
  • on_voip (in-game voip to squad) and on_voip_com (in-game voip to commander or as commander to squad leaders) to e.g. mimick the ingame voip behaviour or address different groups of players
  • target_squad_id (selected squad as commander) to e.g. address a single squad as commander

The existing fields are left untouched, since changing them would break the mumo plugin.

(I just noticed the last peekProc line has a tab instead of 4 spaces; if that's annoying and you can easily edit it, go ahead)

@davidebeatrici davidebeatrici merged commit ffa3be9 into mumble-voip:master May 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidebeatrici

This comment has been minimized.

Copy link
Member

commented May 7, 2017

Thank you very much!

Wiki page updated and PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.