Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioInput, Settings: add 'audio/inputchannelmask' setting for selecting which mic channels should be mixed. #3098

Merged
merged 1 commit into from May 23, 2017

Conversation

@mkrautz
Copy link
Member

commented May 20, 2017

This adds a hidden option to allow users to select which microphone
channels will be downmixed to mono.

Examples of using the setting:

audio/inputchannelmask = 0x0  # Use no channels. Nothing is recorded.
audio/inputchannelmask = 0x1  # Only use left channel (channel index 0)
audio/inputchannelmask = 0x2  # Only use right channel (channel	index 1)
audio/inputchannelmask = 0x3  # Use both left and right channel.

The value of inputchannelmask is used as a bit mask. If a given bit is
set, the channel with the same index as the bit will be included in the
final downmix.

Fixes #3064

imfEcho = chooseMixer(iEchoChannels, eEchoFormat);
uiMicChannelMask = g.s.uiAudioInputChannelMask;

// There is channel mask for the echo canceller.

This comment has been minimized.

Copy link
@mkrautz

mkrautz May 20, 2017

Author Member

Should be: there is no....

@mkrautz mkrautz force-pushed the mkrautz:audio-input-channel-mask branch from f93e06a to aff942d May 20, 2017

AudioInput, Settings: add 'audio/inputchannelmask' setting for select…
…ing which mic channels should be mixed.

This adds a hidden option to allow users to select which microphone
channels will be downmixed to mono.

Examples of using the setting:

	audio/inputchannelmask = 0x0  # Use no channels. Nothing is recorded.
	audio/inputchannelmask = 0x1  # Only use left channel (channel index 0)
	audio/inputchannelmask = 0x2  # Only use right channel (channel	index 1)
	audio/inputchannelmask = 0x3  # Use both left and right channel.

The value of inputchannelmask is used as a bit mask. If a given bit is
set, the channel with the same index as the bit will be included in the
final downmix.

Fixes #3064

@mkrautz mkrautz force-pushed the mkrautz:audio-input-channel-mask branch from aff942d to 03de498 May 20, 2017

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented May 21, 2017

Open questions:

Is 0xffffffffffffffffULL a sensible default value? Should we use 0ULL instead?
That would mean you can't do "0 channels", but... is that a realistic scenario anyway?

@mkrautz mkrautz merged commit 4481729 into mumble-voip:master May 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.