Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble_exe: document LoadLibraryEx workaround for mumble-voip/mumble#2837. #3113

Merged
merged 1 commit into from Jun 3, 2017

Conversation

@mkrautz
Copy link
Member

commented Jun 3, 2017

This adds our bug report from Microsoft Connect inline mumble_exe.cpp
to ensure it's preserved.

It is not obvious why we use the versioned path as the CWD otherwise.

mumble_exe: document LoadLibraryEx workaround for #2837.
This adds our bug report from Microsoft Connect inline mumble_exe.cpp
to ensure it's preserved.

It is not obvious why we use the versioned path as the CWD otherwise.

@mkrautz mkrautz merged commit d3bacc5 into mumble-voip:master Jun 3, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
// 5. CWD
// 6. %PATH% (seemingly)...
//
// But the application doesn't run -- since it doesn't every try to load

This comment has been minimized.

Copy link
@klemun

klemun Jun 3, 2017

'-- since it doesn't every try to load'

type-o here, perhaps you meant 'even' ?

This comment has been minimized.

Copy link
@mkrautz

mkrautz Jun 3, 2017

Author Member

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.