Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASAPI, Settings: expose 'wasapi/role' setting to allow users to set WASAPI role. #3118

Merged
merged 1 commit into from Jun 4, 2017

Conversation

@mkrautz
Copy link
Member

commented Jun 4, 2017

By default, Mumble will open WASAPI devices with the eCommunications role,
since we're a voice chat applicaiton.

Some users have requested this to be configurable.

This commit adds a setting, 'wasapi/role', which is a string that maps
directly to the ERole enum from WASAPI:
https://msdn.microsoft.com/en-us/library/windows/desktop/dd370842

Users can now set 'wasapi/role' to one of 'console', 'multimedia' or
'communications'.

The default is still 'communications'.

@mkrautz mkrautz requested review from hacst and davidebeatrici Jun 4, 2017

/// "console", which should be used for games, system
/// notification sounds, and voice commands.
///
/// "multiemdia", which should be used for music, movies,

This comment has been minimized.

Copy link
@davidebeatrici

davidebeatrici Jun 4, 2017

Member

Typo: "multiemdia" -> "multimedia"

WASAPI, Settings: expose 'wasapi/role' setting to allow users to set …
…WASAPI role.

By default, Mumble will open WASAPI devices with the eCommunications role,
since we're a voice chat applicaiton.

Some users have requested this to be configurable.

This commit adds a setting, 'wasapi/role', which is a string that maps
directly to the ERole enum from WASAPI:
https://msdn.microsoft.com/en-us/library/windows/desktop/dd370842

Users can now set 'wasapi/role' to one of 'console', 'multimedia' or
'communications'.

The default is still 'communications'.

@mkrautz mkrautz force-pushed the mkrautz:wasapi-role branch from 2ff6d11 to 2018934 Jun 4, 2017

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2017

Thanks, fixed.

@mkrautz mkrautz merged commit d66eeeb into mumble-voip:master Jun 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.