Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comparison case-insensitive in ConnectDialog.cpp #3147

Merged
merged 1 commit into from Jul 4, 2017

Conversation

@fwaggle
Copy link
Contributor

commented Jul 4, 2017

Usernames in Murmur aren't case-sensitive, but we only showed the password
field when it was entered as SuperUser, which resulted in some confusion for
users.

Hard-coded the string as lowercase, rather than leaving it and doing an
extra toLower() on it.

Make comparison case-insensitive in ConnectDialog.cpp
Usernames in Murmur aren't case-sensitive, but we only showed the password
field when it was entered as SuperUser, which resulted in some confusion for
users.

Hard-coded the string as lowercase, rather than leaving it and doing an
extra toLower() on it.

@davidebeatrici davidebeatrici added the code label Jul 4, 2017

@mkrautz
mkrautz approved these changes Jul 4, 2017

@mkrautz mkrautz merged commit 455ab19 into mumble-voip:master Jul 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.