Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerHandler: ensure only a single connection timeout timer is active at one time. #3154

Conversation

@mkrautz
Copy link
Member

commented Jul 8, 2017

In #3153, it was reported that the new SRV code can
disconnect you from a server after a short while.

It turns out that we weren't being careful enough about our connection
timeout timer. A new timer was created for each connection attempt to
a server in the SRV list. In practice, this meant that 30 seconds after
each connection attempt, ServerHandler would try to tear down the
connection.

We now ensure we destroy the timer after we disconnect from a server.
This should ensure there is only one such timer active at any point in
time.

Fixes #3153

ServerHandler: ensure only a single connection timeout timer is activ…
…e at one time.

In #3153, it was reported that the new SRV code can
disconnect you from a server after a short while.

It turns out that we weren't being careful enough about our connection
timeout timer. A new timer was created for each connection attempt to
a server in the SRV list. In practice, this meant that 30 seconds after
each connection attempt, ServerHandler would try to tear down the
connection.

We now ensure we destroy the timer after we disconnect from a server.
This should ensure there is only one such timer active at any point in
time.

Fixes #3153

@mkrautz mkrautz force-pushed the mkrautz:serverhandler-fix-connection-timeout-timer branch from 4f1e1df to ffc8bf1 Jul 8, 2017

@davidebeatrici davidebeatrici merged commit 6cd17bd into mumble-voip:master Jul 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.