Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerResolver: treat SRV lookups that return NOERROR but no records as errors. #3172

Merged
merged 1 commit into from Jul 13, 2017

Conversation

@mkrautz
Copy link
Member

commented Jul 13, 2017

This seems like a very sensible change. If no SRV records are retrieved,
treat the situation as an error, and fall back to a regular A/AAAA/CNAME
lookup.

Fixes #3163

ServerResolver: treat SRV lookups that return NOERROR but no records …
…as errors.

This seems like a very sensible change. If no SRV records are retrieved,
treat the situation as an error, and fall back to a regular A/AAAA/CNAME
lookup.

Fixes #3163

@Kissaki Kissaki merged commit 9d4691c into mumble-voip:master Jul 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.