Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay_win: properly terminate our overlay helper processes. #3188

Merged
merged 1 commit into from Jul 20, 2017

Conversation

@mkrautz
Copy link
Member

commented Jul 20, 2017

This gets rid of the errors in the Mumble log about destroying
QProcess instances while they're still running.

@mkrautz mkrautz changed the title WIP: Overlay_win: properly terminate our overlay helper processes. Overlay_win: properly terminate our overlay helper processes. Jul 20, 2017

@mkrautz mkrautz requested review from Kissaki, hacst and davidebeatrici Jul 20, 2017

@Kissaki

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

Where did the issue occur? This introduces calls to terminate, but before that the QProcesses does not seem to be terminated by this parent process.

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2017

The QProcess instances in OverlayPrivateWin are parented to the OverlayPrivateWin class.
The warning happened because the QObject destructor for OverlayPrivateWin would destroy the QProcesses, because they are its children. However, at that point, the processes were still running.
This commit remedies that by terminating the processes before the QObject destructor runs.

Overlay_win: properly terminate our overlay helper processes.
This gets rid of the errors in the Mumble log about destroying
QProcess instances while they're still running.

The QProcess instances in OverlayPrivateWin are parented to the
OverlayPrivateWin class.

The warning happened because the QObject destructor for OverlayPrivateWin
would destroy the QProcesses, because they are its children. However, at
that point, the processes were still running.

This commit remedies that by terminating the processes before the QObject
destructor runs.

@mkrautz mkrautz force-pushed the mkrautz:overlay-win-terminate-helpers branch from 5fa5b1c to 3ea9f08 Jul 20, 2017

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2017

@Kissaki Updated the commit with my text above to proper document the change.

@mkrautz mkrautz merged commit 14ac2b3 into mumble-voip:master Jul 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.