Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MurmurGRPCImpl.h: declare variable for QMutexLocker in RPCSingleStreamCall class. #3201

Merged

Conversation

@mkrautz
Copy link
Member

commented Jul 24, 2017

This existing syntax doesn't build on my Ubuntu 14.04 LTS test machine, and
it seems odd to me.

Change the syntax to something more conventional.

MurmurGRPCImpl.h: declare variable for QMutexLocker in RPCSingleStrea…
…mCall class.

This existing syntax doesn't build on my Ubuntu 14.04 LTS test machine, and
it seems odd to me.

Change the syntax to something more conventional.

@mkrautz mkrautz requested review from Kissaki, hacst and davidebeatrici Jul 24, 2017

@hacst
hacst approved these changes Jul 27, 2017
Copy link
Member

left a comment

LGTM. I have no idea what that would even do...are we even sure that worked at all and didn't just corrupt memory somewhere? How did QMutexLocker even convert a member to pointer to one of the types it accepts... ;)

@mkrautz mkrautz merged commit 2724ff5 into mumble-voip:master Jul 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.