Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalShortcutWin: remove code related to the in-overlay Mumble client. #3204

Merged
merged 2 commits into from Jul 30, 2017

Conversation

@mkrautz
Copy link
Member

commented Jul 24, 2017

We don't support the in-overlay Mumble client in 1.3.x because it doesn't
work correctly on Qt 5.

It's a big hack. Let's wave goodbye.

break;
}

bool suppress = false;

This comment has been minimized.

Copy link
@mkrautz

mkrautz Jul 26, 2017

Author Member

Don't move this.

mkrautz added 2 commits Jul 24, 2017
GlobalShortcutWin: remove code related to the in-overlay Mumble client.
We don't support the in-overlay Mumble client in 1.3.x because it doesn't
work correctly on Qt 5.

It's a big hack. Let's wave goodbye.
GlobalShortcut, GlobalShortcutWin: MumbleApplication: remove GlobalSh…
…ortcut::prepareInput().

This method is unused after the removal of the in-overlay Mumble client
from GlobalShortcutWin.

This commit leaves the nativeEventFilter code in MumbleApplication as-is,
since we're going to need it in a future PR (injection of mouse/key events
from the main thread into GlobalShortcutWin.)

@mkrautz mkrautz force-pushed the mkrautz:gsw-remove-ocintercept branch from 5189fdd to e336368 Jul 29, 2017

@mkrautz

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2017

@hacst
hacst approved these changes Jul 29, 2017
Copy link
Member

left a comment

LGTM

@mkrautz mkrautz merged commit 4f87be8 into mumble-voip:master Jul 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.