Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add greek translation for installer #3214

Merged
merged 1 commit into from Aug 6, 2017

Conversation

@thalieht
Copy link
Contributor

commented Aug 6, 2017

No description provided.

thalieht
@thalieht

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2017

/Offtopic
In https://wiki.mumble.info/wiki/Windows_installers_translations near the end it says:

Add the LCID to the language list in installer/Product.wxl

But it's Product.wxs

@mkrautz
mkrautz approved these changes Aug 6, 2017
Copy link
Member

left a comment

LGTM, and build passes.

Note: If there are bugs in the XML, the installer will, when running on a machine using Greek, possibly fail.
So please test when this hits a snapshot! :-)

@mkrautz mkrautz merged commit cce4851 into mumble-voip:master Aug 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mkrautz

This comment has been minimized.

Copy link
Member

commented Aug 6, 2017

/Offtopic
In https://wiki.mumble.info/wiki/Windows_installers_translations near the end it says:

Add the LCID to the language list in installer/Product.wxl

But it's Product.wxs

Fixed: https://wiki.mumble.info/wiki/Windows_installers_translations
Thanks!

@thalieht thalieht deleted the thalieht:Installer branch Aug 6, 2017

@thalieht

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2017

No problems with 1.3.0-2569-gd196a4b-snapshot 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.