Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crashing on disconnect #3250

Merged
merged 1 commit into from Oct 17, 2017

Conversation

@pchk
Copy link
Contributor

commented Oct 17, 2017

ServerHandler::sendPing must be invoked in the ServerHandler's thread since it contains networking code.
Also there is a direct call to sendPing routine from

void MainWindow::msgServerSync(const MumbleProto::ServerSync &msg) {
        g.sh->sendPing(); // Send initial ping to establish UDP connection
@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

Thank you very much for your contribution!

Some Travis-CI builds failed:

  • MinGW Qt 5 ones for an unrelated problem.
  • GCC Qt4 ones because they use C++98, which doesn't have nullptr.

@mkrautz Do we still have to support older revisions than C++11?

@pchk pchk force-pushed the pchk:fix_crashing branch from c6cf3b7 to 971ff20 Oct 17, 2017

@pchk pchk force-pushed the pchk:fix_crashing branch from 971ff20 to c45957d Oct 17, 2017

@pchk

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2017

Updated once again.
Just dropped nullptr usage, since the fix itself doesn't depend on "C++98" support.

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

That's fine, thank you!

@davidebeatrici davidebeatrici merged commit d2943a5 into mumble-voip:master Oct 17, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.