Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted MinGW fixes #3270

Merged
merged 4 commits into from Nov 26, 2017

Conversation

@mkrautz
Copy link
Member

commented Nov 26, 2017

No description provided.

mkrautz added 3 commits Nov 26, 2017
os_early_win: make compat_layer_env const to avoid GCC writable strin…
…gs error.

GCC is concerned that we'll be writing to the memory of compat_layer_env
after we've assigned a string literal to it.

We won't, but make compat_layer_env const to soothe the compiler.
@@ -386,6 +386,16 @@ win32 {
win32-msvc* {
LIBS *= -lsndfile -lvorbis -lvorbisfile -logg -lFLAC
}

# Boost
LIBS *= -lboost_system-mt

This comment has been minimized.

Copy link
@davidebeatrici

davidebeatrici Nov 26, 2017

Member

Why are we including this for every platform?

This comment has been minimized.

Copy link
@mkrautz

mkrautz Nov 26, 2017

Author Member

This is in the win32 block.

This comment has been minimized.

Copy link
@davidebeatrici

davidebeatrici Nov 26, 2017

Member

Ah, sorry. I didn't see it because I didn't expand the diff.

@mkrautz mkrautz force-pushed the mkrautz:assorted-mingw-fixes branch from 01bfc2f to b65b55c Nov 26, 2017

@mkrautz mkrautz changed the title WIP: Assorted MinGW fixes Assorted MinGW fixes Nov 26, 2017

@mkrautz mkrautz merged commit 2d89506 into mumble-voip:master Nov 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sss123next

This comment has been minimized.

Copy link

commented on e91f282 Nov 28, 2017

thx,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.