Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when handling TCP tunneled UDP voice packets #3326

Merged
merged 1 commit into from Jan 29, 2018

Conversation

@Kissaki
Copy link
Member

commented Jan 29, 2018

0b5579c erroneously replaced the
variable (letter) l with the integer 1.

Revert this change and use a more descriptive variable name len.

Fixes #3325

@Kissaki Kissaki requested review from mkrautz and davidebeatrici Jan 29, 2018

@Kissaki Kissaki force-pushed the Kissaki:fix-3311 branch from d3591ab to 9472fab Jan 29, 2018

@Kissaki

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2018

Fixed the issue number (which I wrongly copied from the title of #3325
Don't mind the wrong branch name

Fix error when handling TCP tunneled UDP voice packets
0b5579c erroneously replaced the
variable (letter) l with the integer 1.

Revert this change and use a more descriptive variable name `len`.

Fixes #3325

@Kissaki Kissaki force-pushed the Kissaki:fix-3311 branch from 9472fab to c8ed9f9 Jan 29, 2018

@Kissaki

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2018

Adjusted commit message and changed varname to len as per suggestion by mkrautz

@Kissaki Kissaki changed the title Fix #3311; replace 1 with l to get previously correct logic Fix error when handling TCP tunneled UDP voice packets Jan 29, 2018

@mkrautz mkrautz merged commit aa90739 into mumble-voip:master Jan 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Kissaki Kissaki deleted the Kissaki:fix-3311 branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.