Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable "You joined channel" and "You have been moved to channel by..." messages #3349

Merged
merged 2 commits into from Mar 1, 2018

Conversation

@davidebeatrici
Copy link
Member

commented Feb 26, 2018

As requested in #1966.

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2018

I accidentally pushed the branch to the master repository, sorry.

@mkrautz

This comment has been minimized.

Copy link
Member

commented Mar 1, 2018

@davidebeatrici Can you do a PR to update the translation strings before this PR? That'll make the diff for the .ts file in this PR more readable. Thanks.

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2018

@mkrautz Sure!

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2018

Translation update
Updating 'mumble_en.ts'...
    Found 1697 source text(s) (3 new and 1694 already existing)
@mkrautz

This comment has been minimized.

Copy link
Member

commented Mar 1, 2018

@davidebeatrici Can you resync against master? :)

@davidebeatrici davidebeatrici force-pushed the join-channel-feedback branch from bf69091 to a02084a Mar 1, 2018

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2018

@mkrautz I was pushing at the exact moment you wrote. :)

@mkrautz
mkrautz approved these changes Mar 1, 2018

@davidebeatrici davidebeatrici merged commit 651e4d0 into master Mar 1, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@davidebeatrici davidebeatrici deleted the join-channel-feedback branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.