Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/rl: single source file for both Linux and Windows #3372

Merged

Conversation

@davidebeatrici
Copy link
Member

commented Mar 15, 2018

No description provided.

@mkrautz
Copy link
Member

left a comment

Not sure this is a win from a code readability perspective.

But you're the maintainer, so you decide.

@@ -3,7 +3,31 @@
// that can be found in the LICENSE file at the root of the
// Mumble source tree or at <https://www.mumble.info/LICENSE>.

#include "../mumble_plugin_win32.h"
#ifdef WIN32
#include "../mumble_plugin_win32.h" // Include standard plugin header.

This comment has been minimized.

Copy link
@mkrautz

mkrautz Mar 15, 2018

Member

Drop comment.

#ifdef WIN32
#include "../mumble_plugin_win32.h" // Include standard plugin header.
#else
#include "../mumble_plugin_linux.h" // Include standard plugin header.

This comment has been minimized.

Copy link
@mkrautz

mkrautz Mar 15, 2018

Member

Drop comment.

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2018

Unfortunately there's one more pointer offset for Windows, otherwise we would've been able to use the same block.

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:rocket-league-plugin branch from 9cf71b1 to ebb79ee Mar 15, 2018

@davidebeatrici davidebeatrici merged commit 208ff15 into mumble-voip:master Mar 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.