Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About: allow text in "About" tab to be selected #3381

Merged
merged 1 commit into from Mar 25, 2018

Conversation

@davidebeatrici
Copy link
Member

commented Mar 25, 2018

Requested in #3380.

@mkrautz

This comment has been minimized.

Copy link
Member

commented Mar 25, 2018

We tend to use the module name, not the name of the implementation file in commits.

So this should be prefixed with "About:" not "About.cpp:".

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:about-dialog branch from ff3f612 to 3575a4c Mar 25, 2018

@davidebeatrici davidebeatrici changed the title About.cpp: allow text in "About" tab to be selected About: allow text in "About" tab to be selected Mar 25, 2018

@mkrautz
Copy link
Member

left a comment

LGTM. Wait for builds.

@davidebeatrici davidebeatrici merged commit 26c732f into mumble-voip:master Mar 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.