Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserModel: show muted/deafened state icon only in the right hand column #3383

Merged
merged 1 commit into from Mar 26, 2018

Conversation

@davidebeatrici
Copy link
Member

commented Mar 26, 2018

See comments in #3368.

@bontibon

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2018

Small issue: the icon is displayed on every user in the tree, not just self

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2018

Oops... I'm going to fix it.

@mkrautz

This comment has been minimized.

Copy link
Member

commented Mar 26, 2018

You probably also need to update the What's This for the user icons to include Push-to-Mute.

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:status-icon branch from 89bed11 to 0c2a023 Mar 26, 2018

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Mar 26, 2018

Done.

@mkrautz
Copy link
Member

left a comment

Code LGTM.

@davidebeatrici davidebeatrici merged commit 109ddd4 into mumble-voip:master Mar 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.