Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JACK: don't start the server if using another backend, create only required ports #3435

Merged
merged 1 commit into from Jul 4, 2018

Conversation

@davidebeatrici
Copy link
Member

commented Jul 3, 2018

This pull request improves JACK support by:

  • starting the server only if JACK is set as audio backend;
  • creating only the ports which are used by Mumble. Previously, both input and output ports were created even if only one of the two directions was being used.

@buscher Feel free to review.

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:jack-v3 branch 2 times, most recently from 5839419 to 473cb11 Jul 3, 2018

@davidebeatrici davidebeatrici changed the title JACK: don't start the server if using another backend, create only required ports [WIP] JACK: don't start the server if using another backend, create only required ports Jul 3, 2018

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:jack-v3 branch 2 times, most recently from 306e6b5 to 14efe3f Jul 4, 2018

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:jack-v3 branch from 14efe3f to e450d80 Jul 4, 2018

@Natenom
Natenom approved these changes Jul 4, 2018
Copy link
Contributor

left a comment

tested, works

@davidebeatrici davidebeatrici changed the title [WIP] JACK: don't start the server if using another backend, create only required ports JACK: don't start the server if using another backend, create only required ports Jul 4, 2018

@davidebeatrici davidebeatrici merged commit 08d9b9c into mumble-voip:master Jul 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.