Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: set user hash and ID on join #3473

Merged

Conversation

@davidebeatrici
Copy link
Member

commented Jul 17, 2018

This fixes a problem with the user's context menu being inaccessible in the join message due to the user's unique link being generated from the Session ID, rather than the hash, as addUser() doesn't set it.

Thanks to @Natenom for reporting the issue.

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:messages-channel-join-leave branch from d888f4a to 7ac210e Jul 17, 2018

Messages: set user hash and ID on server join
This fixes a problem with the context menu being inaccessible in the join message due to the user's link being generated from the Session ID, rather than the hash, as addUser() doesn't set it.

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:messages-channel-join-leave branch from 7ac210e to 3a51d6b Jul 17, 2018

@davidebeatrici davidebeatrici merged commit 86197ff into mumble-voip:master Jul 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.