Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use Mumble theme icons for the system theme #3475
Jul 18, 2018
Yes, I'm going to add screenshots with the white system theme in the pull request message.
It's to maintain consistency and because the current icons we use for the "None" theme are not as good as the Mumble theme's ones.
I reworded the commits.
I agree the icons look better.
Could be shortened to:?
When setting the skin path, wouldn't that mean it would use that skin rather than only those icons? Does this only work because we don't reload those/all resources? I'm not sure I like that. I'm also not sure how else to implement this; replicating the icons in another would be an option.
We also now depend on the themes submodule. Which is kind of okay, but being able to build Mumble without this dependency seems like an advantage. Especially since the theme(s) is(/are) licensed differently. So considering/concerning this I’m not sure if this would be a good change. Maybe we can just update our icons - if license allows that, re-licensing, or adding a third pary license.
What is the reasoning for moving icons? Those are icons we no longer use? Why not remove them?
Tango icons are removed. I believe we have third party license logic/infos that are not being removed here?
Just a comment, having "none" use the system theme is preferable to some of us and we do like using these newer/cleaner icons with our system theme opposed to the all white/black themes.
This should look similar to how Teamspeak 3 looks, cleaner/flatter icons with still the professional looking Win32 "rendering" of how QT draws GUI elements with "none" selected.
The style is applied here:
Our theme is licensed under Unlicense: https://github.com/mumble-voip/mumble-theme/blob/master/LICENSE
"A license with no conditions whatsoever which dedicates works to the public domain. Unlicensed works, modifications, and larger works may be distributed under different terms and without source code."
Yes, those are icons we no longer use.
I didn't remove them because they are our own, but I can do it if you prefer.
I didn't find any info aside from: