Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: copy rnnoise.dll #3481

Merged
merged 1 commit into from Jul 21, 2018

Conversation

@davidebeatrici
Copy link
Member

commented Jul 20, 2018

Fixes #3477.

The file copy can be disabled with the MumbleNoRNNoise environment variable.

installer: copy rnnoise.dll
The file copy can be disabled with the MumbleNoRNNoise environment variable.
@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2018

@edm7707 Your Git configuration is now correct.

I created a new pull request to get rid of the merge commit and use a clean branch, like I did with #3434.

@edm7707

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2018

For this to be merged, I don't need to anything more on my end?

Do one of the other Mumble ppls have to review it ? .. seems like a few pulls stuck in review limbo 😄

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2018

It's ready to be merged, but a review from another team member is required.

@davidebeatrici davidebeatrici merged commit 7c08da0 into mumble-voip:master Jul 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.