Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JackAudio: change disconnect_ports() so that it uses stored ports instead of retrieving them using jack_get_ports() #3490

Merged

Conversation

@davidebeatrici
Copy link
Member

commented Aug 2, 2018

jack_get_ports() returns all the ports registered on the JACK server, unless a name pattern is specified, which means that Mumble disconnected ports registered by other clients.

This commit changes disconnect_ports() so that it disconnects the ports which are stored in our internal variables, making it faster.

Fixes #3489.

JackAudio: change disconnect_ports() so that it uses stored ports ins…
…tead of retrieving them using jack_get_ports()

jack_get_ports() returns all the ports registered on the JACK server, unless a name pattern is specified, which means that Mumble disconnected ports registered by other clients.

This commit changes disconnect_ports() so that it disconnects the ports which are stored in our internal variables, making it faster.
@Natenom
Copy link
Contributor

left a comment

works

@Natenom
Natenom approved these changes Aug 2, 2018

@davidebeatrici davidebeatrici merged commit d3cf441 into mumble-voip:master Aug 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.