Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: compile plugins for Windows games also on Linux, for Proton/Wine support #3511



Copy link

Support for Wine was added in #2512.

Copy link

@Kissaki Kissaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s up the with include change?

How is enabling this done? What changes?

plugins/mumble_plugin_utils.h Outdated Show resolved Hide resolved
Copy link
Member Author

davidebeatrici commented Aug 30, 2018

What’s up with the include change?

The new header includes mumble_plugin_win32.h on Windows and mumble_plugin_linux.h on Linux, to eliminate the need of writing in every source file:

#ifdef WIN32
#include "../mumble_plugin_win32.h" // Include standard plugin header.
#include "../mumble_plugin_linux.h" // Include standard plugin header.

How is enabling this done? What changes?

This pull request changes so that all plugins are built on Linux and fixes compile errors caused by the use of non-standard functions.

@davidebeatrici davidebeatrici force-pushed the positional-audio-wine branch 2 times, most recently from af28c34 to 81aae2b Compare October 11, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants