Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins: compile plugins for Windows games also on Linux, for Proton/Wine support #3511

Merged
merged 5 commits into from Oct 11, 2019
Merged

plugins: compile plugins for Windows games also on Linux, for Proton/Wine support #3511

merged 5 commits into from Oct 11, 2019

Conversation

davidebeatrici
Copy link
Member

Support for Wine was added in #2512.

@davidebeatrici davidebeatrici force-pushed the positional-audio-wine branch 4 times, most recently from d6e2f97 to b26985d Compare August 30, 2018 15:14
@davidebeatrici davidebeatrici requested review from Kissaki, a user, hacst and mkrautz August 30, 2018 16:02
Kissaki
Kissaki reviewed Aug 30, 2018
View reviewed changes
Copy link
Member

@Kissaki Kissaki left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What’s up the with include change?

How is enabling this done? What changes?

plugins/mumble_plugin_utils.h Outdated Show resolved Hide resolved
@davidebeatrici
Copy link
Member Author

davidebeatrici commented Aug 30, 2018 •
edited

What’s up with the include change?

The new header includes mumble_plugin_win32.h on Windows and mumble_plugin_linux.h on Linux, to eliminate the need of writing in every source file:

#ifdef WIN32
#include "../mumble_plugin_win32.h" // Include standard plugin header.
#else
#include "../mumble_plugin_linux.h" // Include standard plugin header.
#endif

How is enabling this done? What changes?

This pull request changes plugins.pro so that all plugins are built on Linux and fixes compile errors caused by the use of non-standard functions.

@davidebeatrici davidebeatrici mentioned this pull request Aug 7, 2019
Closed
@davidebeatrici davidebeatrici force-pushed the positional-audio-wine branch 2 times, most recently from af28c34 to 81aae2b Compare October 11, 2019 20:45
@davidebeatrici davidebeatrici merged commit b54351c into mumble-voip:master Oct 11, 2019
@davidebeatrici davidebeatrici mentioned this pull request Oct 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kissaki Kissaki Kissaki left review comments

@rpmjava rpmjava rpmjava left review comments

@hacst hacst Awaiting requested review from hacst

@mkrautz mkrautz Awaiting requested review from mkrautz

Assignees
No one assigned
Labels
client linux positional audio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidebeatrici @Kissaki @rpmjava