Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower bucket params #3512

Merged
merged 1 commit into from Aug 31, 2018
Merged

Lower bucket params #3512

merged 1 commit into from Aug 31, 2018

Conversation

@tu-maurice
Copy link
Contributor

@tu-maurice tu-maurice commented Aug 30, 2018

I guess I was too generous with the bucket parameters. My bad.

After some more testing this evening a "1 message per second, 5 messages burst" limit is still sufficient enough to not annoy people under normal circumstances.

Use 1 tokens per second and 5 burst instead of 4 tokens per second and 30 burst
@ailox ailox mentioned this pull request Aug 30, 2018
@tu-maurice tu-maurice force-pushed the tu-maurice:exploitpatch branch from 934aa2b to 4761ca4 Aug 30, 2018
@tu-maurice
Copy link
Contributor Author

@tu-maurice tu-maurice commented Aug 30, 2018

Forgot to change the comment, my bad.

@promi
Copy link

@promi promi commented Aug 30, 2018

I would remove the numbers from the comment altogether, they don't add any useful information.

@davidebeatrici
Copy link
Member

@davidebeatrici davidebeatrici commented Aug 31, 2018

I would remove the numbers from the comment altogether, they don't add any useful information.

They will be removed when we make the two parameters configurable in Murmur's configuration file.

@davidebeatrici davidebeatrici merged commit f7221c1 into mumble-voip:master Aug 31, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants