Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drop indices on MySQL #3564

Merged
merged 1 commit into from Dec 18, 2018

Conversation

@lorenz
Copy link
Contributor

commented Dec 18, 2018

This is a bad idea since it tries to delete primary key indices, which fails on modern MySQL/MariaDB versions thus breaking the upgrade process in the middle. The only way to recover is to rename all tables back to their original names, pull out this code and let it upgrade again. Also it seems pointless to me since all tables and thus their indices are getting destroyed afterwards anyways.

@davidebeatrici davidebeatrici merged commit 16c1145 into mumble-voip:master Dec 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

Thank you very much for your contribution!

@androos androos referenced this pull request Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.