Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASAPI: print log message when the OS blocks access to the microphone #3572

Conversation

@davidebeatrici
Copy link
Member

commented Jan 8, 2019

Requested in #3347.

Many users reported that no messages are shown in case Mumble is unable to access the microphone, aside from a simple message with the error code (0x80070005) in the developer console.

This is an issue because since Windows 10 1803 the privacy settings also apply to desktop applications, causing the microphone not to work anymore in many programs (including Mumble) if the user disables access to the microphone globally.

@davidebeatrici davidebeatrici requested review from mkrautz, Kissaki and hacst Jan 8, 2019

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:wasapi-microphone-access-denied-message branch from 61cc477 to 8d3af29 Jan 8, 2019

@Kissaki

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

The commit (and consequently this PR) should be self contained. It should explain why it does what it does.

@Kissaki

This comment has been minimized.

Copy link
Member

commented Jan 12, 2019

Suggestion in the PR description is better. But I’d swap the paragraphs for a better flow of information - why we do it first (reasoning), and then why it became important now (impact).

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:wasapi-microphone-access-denied-message branch from 8d3af29 to cd31bc3 Jan 13, 2019

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2019

Done, I also updated the commit's description.

@Kissaki
Copy link
Member

left a comment

please check its privacy settings

Not sure if that’s a good, reasonable assumption and wording to make.

Maybe a more general “Please check your operating system microphone settings allow Mumble to use the microphone.” would be more fitting?

Personally I’d make it two full stop sentences as well. Simplifying the text.

@davidebeatrici

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2019

"Access to the microphone was denied. Please check that your operating system's microphone settings allow Mumble to use the microphone."?

@Kissaki

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

Yes, I prefer that.

WASAPI: print log message when the OS blocks access to the microphone
Many users reported that no messages are shown in case Mumble is unable to access the microphone, aside from a simple message with the error code (0x80070005) in the developer console.

This is an issue because since Windows 10 1803 the privacy settings also apply to desktop applications, causing the microphone not to work anymore in many programs (including Mumble) if the user disables access to the microphone globally.
Translation update
Updating 'mumble_en.ts'...
    Found 1714 source text(s) (1 new and 1713 already existing)

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:wasapi-microphone-access-denied-message branch from cd31bc3 to b01639d Jan 13, 2019

@davidebeatrici davidebeatrici merged commit b981566 into mumble-voip:master Jan 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.