Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectDialog: create "Unknown" continent, never expand it automatically #3580

Conversation

@davidebeatrici
Copy link
Member

commented Jan 17, 2019

  1. There are currently two servers appearing in a non-existent continent and country because their public IP addresses are part of two blocks assigned recently which are not in our GeoIP database.

This commit adds a new continent called "Unknown" without countries, which replaces the "ghost" continent and category.

  1. If the user's public IP address was not in our GeoIP database, the "Unknown" continent and country categories were expanded because the strings resulted empty.

This commit adds a check to make sure that those categories are never expanded automatically.


Before:
mumble_connectdialog_unknown_continent_previous

After:
mumble_connectdialog_unknown_continent

@davidebeatrici davidebeatrici requested review from mkrautz, Kissaki and hacst Jan 17, 2019

@mumble-voip mumble-voip deleted a comment from davidebeatrici Jan 17, 2019

ConnectDialog: create "Unknown" continent, never expand it automatically
1. There are currently two servers appearing in a non-existent continent and country because their public IP addresses are part of two blocks assigned recently which are not in our GeoIP database.

This commit adds a new continent called "Unknown" without countries, which replaces the "ghost" continent and category.

2. If the user's public IP address was not in our GeoIP database, the "Unknown" continent and country categories were expanded because the strings resulted empty.

This commit adds a check to make sure that those categories are never expanded automatically.
Translation update
Updating 'mumble_en.ts'...
    Found 1716 source text(s) (2 new and 1714 already existing)

@davidebeatrici davidebeatrici force-pushed the davidebeatrici:connectdialog-empty-category-fix branch from 31f8650 to f041737 Jan 17, 2019

@hacst
hacst approved these changes Jan 17, 2019
Copy link
Member

left a comment

LGTM. Once CI passes feel free to merge.

@davidebeatrici davidebeatrici merged commit 66f5ae9 into mumble-voip:master Jan 17, 2019

2 checks passed

Mumble-CI Build #20190117.3 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.