Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global: fix migrateDataDir() not migrating the data directory #3587

Merged

Conversation

@davidebeatrici
Copy link
Member

commented Jan 25, 2019

Fixes #1702.


rename() was failing because it doesn't expect the new directory to exist.

From Qt's documentation (http://doc.qt.io/qt-5/qdir.html#rename):

On most file systems, rename() fails only if oldName does not exist, or if a file with the new name already exists.

Global: fix migrateDataDir() not migrating the data directory
rename() was failing because it doesn't expect the new directory to exist.

From Qt's documentation (http://doc.qt.io/qt-5/qdir.html#rename):
"On most file systems, rename() fails only if oldName does not exist, or if a file with the new name already exists."

@davidebeatrici davidebeatrici merged commit 6e70999 into mumble-voip:master Jan 25, 2019

2 checks passed

Mumble_CI Build #20190125.4 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.