Remove Qt 4 stuff #3602
Merged
Remove Qt 4 stuff #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
force-pushed
the
no-qt4
branch
from
77c9b45
to
8c9f858
Compare
davidebeatrici
commented
Mar 19, 2019
davidebeatrici
force-pushed
the
no-qt4
branch
2 times, most recently
from
0d9342a
to
86c9656
Compare
davidebeatrici
force-pushed
the
no-qt4
branch
from
a9f1409
to
f8d31fa
Compare
|
I don’t like the commit (and PR) description. It doesn’t tell anything. |
|
For reference https://wiki.qt.io/Transition_from_Qt_4.x_to_Qt5 |
davidebeatrici
force-pushed
the
no-qt4
branch
from
f8d31fa
to
9a1936f
Compare
8 tasks
Qt 4 used a different implementation because QDnsLookup was introduced in Qt 5. Unlike the complete implementation, the Qt 4 compatible one only supported simple lookups (e.g. hostname -> IP address).
davidebeatrici
force-pushed
the
no-qt4
branch
from
9a1936f
to
2b9b1ed
Compare
davidebeatrici
force-pushed
the
no-qt4
branch
from
2b9b1ed
to
1ac5349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#3484
For reference https://wiki.qt.io/Transition_from_Qt_4.x_to_Qt5