Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TLS 1.3 in the server information window #3663

Merged
merged 1 commit into from Apr 7, 2019

Conversation

@jeandeaual
Copy link
Contributor

commented Apr 7, 2019

When connecting to a server using TLS 1.3, the server information windows displays "The connection uses UnknownProtocol".
This pull request fixes that by adding a case for QSsl::TlsV1_3 in MumbleSSL::protocolToString(QSsl::SslProtocol protocol).

See https://doc.qt.io/qt-5/qssl.html#SslProtocol-enum

Before:

mumble_unknown_protocol

After:

mumble_tls1 3

@davidebeatrici davidebeatrici merged commit 4c82dd5 into mumble-voip:master Apr 7, 2019

5 checks passed

CI Build #20190407.2 succeeded
Details
CI (Windows MSVC_2015) Windows MSVC_2015 succeeded
Details
CI (Windows MSVC_2015_NO_PCH) Windows MSVC_2015_NO_PCH succeeded
Details
CI (macOS) macOS succeeded
Details
Travis CI - Pull Request Build Passed
Details
@davidebeatrici

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.