Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
JackAudio: fix segmentation fault, revamp initialization logic #3683
The crash happens when an invalid client is passed to
This pull request changes
The downside to moving the client initialization into the constructor is that it stays open (but not active) even when JACK is not used as backend, which is what currently happens with the PulseAudio backend.
In future we will improve the way audio backends are handled and fix the issue.
With this PR there is no freezes or crashes related to JACK, but now even with
I've tested against 1.3.0rc1 and Mumble+JACK seems to work properly on my system (with a dummy backend)
From the commit message: