Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/package murmur in a docker image #3690

Merged
merged 2 commits into from May 9, 2019

Conversation

@gclawes
Copy link
Contributor

commented May 8, 2019

Closes #3688.

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented May 8, 2019

From Cirrus CI:

error building image: error building stage: lstat /workspace/scripts/murmur.ini: no such file or directory
@gclawes

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Does Cirrus CI support multi-stage builds?

@davidebeatrici

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@gclawes

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Looks like the offending line is COPY ./scripts/murmur.ini /etc/murmur/murmur.ini, not the multi-stage copy before it.

It builds locally in docker, is Cirrus using something else to build images?

Step 11/16 : COPY --from=0 /root/mumble/release/murmurd /usr/bin/murmurd
 ---> 41561da5be08
Step 12/16 : COPY ./scripts/murmur.ini /etc/murmur/murmur.ini
---> 8ab3c5a4c6d8
@gclawes

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

This may be down to a difference between docker and kaniko, I'll look into that.

@gclawes

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@gclawes

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

I tried switching the order of the copy statements, confirmed that it's the one for murmur.ini that's failing. At this point I'm not sure what else to do, other than try a single-stage build. It seems like this is down to a bug in kaniko (the builder used by Cirrus), as the build succeeds under docker locally and DockerHub.

@gclawes gclawes force-pushed the gclawes:docker branch from 65d1a01 to 59c1c02 May 8, 2019

@bendem

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

have you tried copying it from the previous stage instead of the host?

@bendem

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Looks like that did it.

@gclawes

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Sounds good, let me squash that commit before this is merged.

Build/package murmur in a docker image
Built in ubuntu:disco, packed in clean ubuntu:disco image with runtime
dependencies using multistage build

Resolves #3688

Signed-off-by: Graeme Lawes <graemelawes@gmail.com>

@gclawes gclawes force-pushed the gclawes:docker branch from 7c38f07 to 041136d May 9, 2019

@gclawes

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Done.

@davidebeatrici davidebeatrici changed the title Build/package murmur in a docker image Build/package murmur in a docker image May 9, 2019

@davidebeatrici davidebeatrici merged commit cbbc342 into mumble-voip:master May 9, 2019

4 of 6 checks passed

CI Build #20190509.4 failed
Details
CI (macOS) macOS failed
Details
CI (Windows MSVC_2015) Windows MSVC_2015 succeeded
Details
CI (Windows MSVC_2015_NO_PCH) Windows MSVC_2015_NO_PCH succeeded
Details
Docker Build Task Summary
Details
Travis CI - Pull Request Build Passed
Details
@davidebeatrici

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.