Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize window on tray icon click #3691

Merged
merged 1 commit into from May 9, 2019

Conversation

@retificator
Copy link
Contributor

commented May 8, 2019

Closes #3680.

This pull request changes MainWindow::on_Icon_activated() so that it minimizes Mumble's window if it's not already.

Previously, no action occurred when clicking on the tray icon while the window was shown.

@davidebeatrici davidebeatrici changed the title maximize-window-on-tray-icon-click Minimize window on tray icon click May 8, 2019

@retificator retificator force-pushed the retificator:retificator-patch-1 branch from d14cd4f to 5e0713e May 8, 2019

Minimize window on tray icon click
This pull request changes MainWindow::on_Icon_activated() so that it minimizes Mumble's window if it's not already.

Previously, no action occurred when clicking on the tray icon while the window was shown.

@retificator retificator force-pushed the retificator:retificator-patch-1 branch from 5e0713e to 48e793e May 8, 2019

@davidebeatrici davidebeatrici merged commit 5a4f4cd into mumble-voip:master May 9, 2019

3 of 5 checks passed

CI Build #20190508.8 failed
Details
CI (macOS) macOS failed
Details
CI (Windows MSVC_2015) Windows MSVC_2015 succeeded
Details
CI (Windows MSVC_2015_NO_PCH) Windows MSVC_2015_NO_PCH succeeded
Details
Travis CI - Pull Request Build Passed
Details
@davidebeatrici

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.