Revamp JackAudio implementation #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users were encountering issues such as the client taking ~8 seconds to start when "jackd" could not be run, due to the library attempting many times to connect to the JACK server (https://bugs.debian.org/941455). While working on a fix I corrected the many warnings emitted by Clang-Tidy and I realized that there were many things that could be improved. This commit almost entirely rewrites the implementation, but here are some of the changes: - Mutexes are used everywhere, race conditions should not be possible anymore. - The JACK client is not opened until it's required (i.e. "JackAudioInput" and/or "JackAudioOutput" start running). The initialization code has been moved to a dedicated function, the constructor doesn't execute it anymore. This is what fixes the issue mentioned above. - The JACK client is deactivated and closed automatically when both "JackAudioInput" and "JackAudioOutput" are not running. - Code specific to audio input or audio output has been moved from "JackAudioSystem" to the corresponding section ("JackAudioInput" or "JackAudioOutput"). - Some variables in "JackAudioSystem" have been replaced with functions which retrieve the corresponding value from the JACK server. - Removed all instances of "delete", raw pointers have been replaced with "std::unique_ptr<>()". - Replaced "NULL" with "nullptr".
davidebeatrici
force-pushed
the
jack-audio-revamp
branch
from
a3ba863
to
01b097d
Compare
This was referenced Oct 8, 2019
|
@crknadle kindly tested the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some users were encountering issues such as the client taking ~8 seconds to start when
jackdcould not be run, due to the library attempting many times to connect to the JACK server (#3822).While working on a fix I corrected the many warnings emitted by Clang-Tidy and I realized that there were many things that could be improved.
This commit almost entirely rewrites the implementation, but here are some of the changes:
JackAudioInputand/orJackAudioOutputstart running). The initialization code has been moved to a dedicated function, the constructor doesn't execute it anymore. This is what fixes [Linux] jackd support without jackd installed causes Mumble client startup delay #3822.JackAudioInputandJackAudioOutputare not running.JackAudioSystemto the corresponding section (JackAudioInputorJackAudioOutput).JackAudioSystemhave been replaced with functions which retrieve the corresponding value from the JACK server.delete, raw pointers have been replaced withstd::unique_ptr<>().NULLwithnullptr.