Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to toggle 24-hour time format for the chat #3827

Merged

Conversation

davidebeatrici
Copy link
Member

By default QTime uses the 24-hour time format when converting to a string.

This commit adds a setting (a checkbox) which allows users to toggle the format.

The setting only applies for new messages, the already shown ones will retain the previous time format.


Fixes #3823.

@davidebeatrici davidebeatrici added client feature-request This issue or PR deals with a new feature labels Oct 4, 2019
@davidebeatrici davidebeatrici added this to the 1.4.0 milestone Oct 4, 2019
By default QTime uses the 24-hour time format when converting to a string.

This commit adds a setting (a checkbox) which allows users to toggle the format.

The setting only applies for new messages, the already shown ones will retain the previous time format.
@davidebeatrici davidebeatrici merged commit cf81dee into mumble-voip:master Oct 11, 2019
@Kissaki
Copy link
Member

Kissaki commented Oct 12, 2019

The OS has and provides information of regional and formatting settings. We should use that instead of duplicating those settings.

When was this issue introduced? 1.3.0? Or afterwards in the snapshots?

@davidebeatrici
Copy link
Member Author

The OS has and provides information of regional and formatting settings. We should use that instead of duplicating those settings.

I initially used Qt::DefaultLocaleShortDate, which is what we currently do for the date, the issue is that seconds are not shown.

With Qt::DefaultLocaleLongDate seconds are shown, but the timezone (e.g. "UTC") appears as well.

QLocale::system().timeFormat(QLocale::ShortFormat) returns h:mm AP.

QLocale::system().timeFormat(QLocale::LongFormat) returns h:mm:ss AP t.

When was this issue introduced? 1.3.0? Or afterwards in the snapshots?

According to #3823 it appeared with Mumble 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing of chat timestamps to 12 hour from the current 24 hour
2 participants