Remove DirectSound implementation #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirectSound was the first audio backend supported by Mumble, in 2005. Windows Vista introduced a brand new audio stack called WASAPI, which entirely replaced DirectSound. Support for it was added in 9a01814, 6bef650 and 677a399. This commit entirely removes our DirectSound implementation, not needed anymore because we are dropping support for Windows XP in 1.4.
The suggestion to use DirectSound was valid only for Windows versions prior to Vista, because WASAPI was introduced with it. Fortunately DirectSound didn't appear in the UI as an option in case WASAPI was detected, hopefully we didn't mislead users into thinking that DirectSound is better than WASAPI. Also, the description was suggesting to use DirectSound on non-Windows operating systems.
Updating 'mumble_en.ts'...
Found 1717 source text(s) (14 new and 1703 already existing)
Removed 15 obsolete entries
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectSound was the first audio backend supported by Mumble, in 2005.
Windows Vista introduced a brand new audio stack called WASAPI, which entirely replaced DirectSound. Support for it was added in 9a01814, 6bef650 and 677a399.
This commit entirely removes our DirectSound implementation, not needed anymore because we are dropping support for Windows XP in 1.4.