Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JackAudio: load symbols at runtime #3876



Copy link

"types.h" contains types we need, such as the various enums.

The header is added in a directory called "jack", so that the path (<jack/types.h>) matches the system one ("/usr/include/jack/types.h" usually).
We check for the following libraries:

- Windows: "libjack64.dll" and "libjack32.dll". Those are the libraries that are shipped with the official installer, which copies them in "C:\Windows".
- macOS: "libjack.dylib" and "libjack.0.dylib".
- Everything else: "" and "".

This commit also:

- Adds a debug message so that a user knows which library was loaded and its version.
- Renames "inputBuffer" to "outputBuffer" in JackAudioOutput::process(), the previous name was only correct from the perspective of the JACK port.
- Renames "input" to "inputBuffer" in JackAudioInput::process(), the previous name was unclear.
@davidebeatrici davidebeatrici added client build Everything related to compiling/building the code release-management audio labels Oct 31, 2019
Copy link

McKayJT commented Nov 4, 2019

I have tested this set of patches and JACK loads and plays/records just fine with them in place. It will even start the server if it's not running like it's supposed to be doing.

Copy link
Member Author

Thank you very much for testing the pull request!

@davidebeatrici davidebeatrici merged commit 8cdc8f4 into mumble-voip:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
audio build Everything related to compiling/building the code client release-management
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants