JackAudio: load symbols at runtime #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"types.h" contains types we need, such as the various enums.
The header is added in a directory called "jack", so that the path (<jack/types.h>) matches the system one ("/usr/include/jack/types.h" usually).
…clude path This guarantees no dependency.
We check for the following libraries: - Windows: "libjack64.dll" and "libjack32.dll". Those are the libraries that are shipped with the official installer, which copies them in "C:\Windows". - macOS: "libjack.dylib" and "libjack.0.dylib". - Everything else: "libjack.so" and "libjack.so.0". This commit also: - Adds a debug message so that a user knows which library was loaded and its version. - Renames "inputBuffer" to "outputBuffer" in JackAudioOutput::process(), the previous name was only correct from the perspective of the JACK port. - Renames "input" to "inputBuffer" in JackAudioInput::process(), the previous name was unclear.
davidebeatrici
added
client
build
davidebeatrici
force-pushed
the
jack-audio-runtime-load
branch
from
2c3fbb3
to
13b7e67
Compare
|
I have tested this set of patches and JACK loads and plays/records just fine with them in place. It will even start the server if it's not running like it's supposed to be doing. |
|
Thank you very much for testing the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#3794