Revamp PortAudio implementation #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebeatrici
added
client
build
davidebeatrici
force-pushed
the
portaudio-revamp
branch
from
87e8d0b
to
c089b3f
Compare
While working on the code to load the library at runtime, I corrected the many warnings emitted by Clang-Tidy and I realized that there were many things that could be improved. This commit almost entirely rewrites the implementation, but here are some of the changes: - Symbols are loaded at runtime, the library is not a dependency anymore. - A callback is used to read/write from/to the stream. - "PortAudioSystem" is not a static class anymore, the object is managed by "PortAudioInit". - All instances of "delete" have been removed, raw pointers have been replaced with "std::unique_ptr<>()". - All instances of "NULL" have been replaced with "nullptr".
…src" as include path This guarantees no dependency.
davidebeatrici
force-pushed
the
portaudio-revamp
branch
from
c089b3f
to
bdd32fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
While working on the code to load the library at runtime, I corrected the many warnings emitted by Clang-Tidy and I realized that there were many things that could be improved.
This commit almost entirely rewrites the implementation, but here are some of the changes:
PortAudioSystemis not a static class anymore, the object is managed byPortAudioInit.deletehave been removed, raw pointers have been replaced withstd::unique_ptr<>().NULLhave been replaced withnullptr.