Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message style #4026

merged 4 commits into from Apr 6, 2020


Copy link

@Krzmbrzl Krzmbrzl commented Apr 1, 2020

See individual commit messages for what has been done. In here I only want to provide some screenshots.

Before this PR:

After this PR:

Fixes #1590 by only drawing borders around messages that end with one or more empty lines. If a message contains line-breaks in between or at the beginning, we no longer draw a border around the message as its start and end are clearly visible to the user.

Right now the first message logged after a message that has been logged
with a frame drawn around it, has a comparatively huge spacing to said
This is because in the old implementation an additional empty block
sneaked in after the frame, causing the spacing.
With this commit it is checked whether there already exists an empty
block that can be written into before creating a new one.
This commit adds a setting for specifying the margins for logged
messages. With the default value for this, messages are also spaced out
more than they have been before this commit (if you don't like it, set
the margin to 0 and you're back at the old style).

This commit also changes the framestyle to dashed in order to make
frames less intrusive on the eye if they have to be drawn.
Updating 'mumble_en.ts'...
    Found 1724 source text(s) (3 new and 1721 already existing)
    Removed 1 obsolete entries
@Krzmbrzl Krzmbrzl merged commit 005cdfc into mumble-voip:master Apr 6, 2020
@Krzmbrzl Krzmbrzl added this to the 1.4.0 milestone Apr 6, 2020
@Krzmbrzl Krzmbrzl deleted the restyle-log-messages branch November 9, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Remove border from multi-line TextChat-messages
1 participant