Improve log message style #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the first message logged after a message that has been logged with a frame drawn around it, has a comparatively huge spacing to said frame. This is because in the old implementation an additional empty block sneaked in after the frame, causing the spacing. With this commit it is checked whether there already exists an empty block that can be written into before creating a new one.
This commit adds a setting for specifying the margins for logged messages. With the default value for this, messages are also spaced out more than they have been before this commit (if you don't like it, set the margin to 0 and you're back at the old style). This commit also changes the framestyle to dashed in order to make frames less intrusive on the eye if they have to be drawn.
Updating 'mumble_en.ts'...
Found 1724 source text(s) (3 new and 1721 already existing)
Removed 1 obsolete entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See individual commit messages for what has been done. In here I only want to provide some screenshots.
Before this PR:
After this PR:
Fixes #1590 by only drawing borders around messages that end with one or more empty lines. If a message contains line-breaks in between or at the beginning, we no longer draw a border around the message as its start and end are clearly visible to the user.