src/murmur/Server.cpp: implement workaround for critical QSslSocket issue #4032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #3679.
A severe bug was introduced in qt/qtbase@93a803a:
q_SSL_shutdown()causes Qt to emiterror()from unrelatedQSslSocket(s), in addition to the correct one.The issue causes
Server::connectionClosed()to disconnect random authenticated clients.The workaround consists in ignoring a specific OpenSSL error:
Definitely not ideal, but it fixes a critical vulnerability. Details on how to trigger it are deliberately omitted.