Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper to selection #4048

merged 4 commits into from Apr 9, 2020


Copy link

@Krzmbrzl Krzmbrzl commented Apr 6, 2020

Implements #1548

It works by adding a shortcut for the normal Whisper/Shout functionality but then in the changed UI of selecting the target for that action you'll have to select Current selection

@Krzmbrzl Krzmbrzl added this to the 1.4.0 milestone Apr 6, 2020
@Krzmbrzl Krzmbrzl linked an issue Apr 6, 2020 that may be closed by this pull request
Before it was only possible to set hotkeys for whispering/shouting to
fixed targets (e.g. a certain list of users or a certain channel).

This commit adds the possibility to set up a hotkey to whisper/shout to
whatever is the current selection in the UI. That means if I have
another user selected, then I'll whisper to that user and if I have a
channel selected, then I'll shout to that instead.
Updating 'mumble_en.ts'...
    Found 1726 source text(s) (7 new and 1719 already existing)
    Removed 3 obsolete entries
@Krzmbrzl Krzmbrzl force-pushed the feature-whisper-to-selected branch from 889e63e to 954299d Compare April 9, 2020 08:52
@Krzmbrzl Krzmbrzl merged commit 14e6e6a into mumble-voip:master Apr 9, 2020
@Krzmbrzl Krzmbrzl mentioned this pull request Apr 17, 2020
Krzmbrzl added a commit that referenced this pull request Apr 30, 2020
The TalkingUI is meant as some sort of a light version of the Overlay
primarily intended for use when using the computer normally (e.g. with
many different programs instead of one that is FullScreen).

It consists of a small window that can be toggled and it will show the
names of the person currently talking as well as the channel that person
is in.

If a person has stopped talking for some time (5s in the current
implementation), it will be removed from the UI again.

By default the UI will stay on top of all other windows so that you'll
always be able to see it.

Note that the selection in the TalkingUI and the MainWindow is synchronised in terms of selected users (if a channel is selected, the TalkingUI will not show a selection).
This means that this feature plays nicely with the "Whisper to selected" feature (#4048): Select a user in the TalkingUI and you can will use that user as a whisper target if you have your shortcut set to whisper to the currently selected item.
@Krzmbrzl Krzmbrzl deleted the feature-whisper-to-selected branch November 9, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Hotkey to whisper selected user
1 participant