Whisper to selection #4048
Merged
Whisper to selection #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was only possible to set hotkeys for whispering/shouting to fixed targets (e.g. a certain list of users or a certain channel). This commit adds the possibility to set up a hotkey to whisper/shout to whatever is the current selection in the UI. That means if I have another user selected, then I'll whisper to that user and if I have a channel selected, then I'll shout to that instead.
Updating 'mumble_en.ts'...
Found 1726 source text(s) (7 new and 1719 already existing)
Removed 3 obsolete entries
Krzmbrzl
force-pushed
the
feature-whisper-to-selected
branch
from
889e63e
to
954299d
Compare
Merged
Krzmbrzl
added a commit
that referenced
this pull request
Apr 30, 2020
The TalkingUI is meant as some sort of a light version of the Overlay primarily intended for use when using the computer normally (e.g. with many different programs instead of one that is FullScreen). It consists of a small window that can be toggled and it will show the names of the person currently talking as well as the channel that person is in. If a person has stopped talking for some time (5s in the current implementation), it will be removed from the UI again. By default the UI will stay on top of all other windows so that you'll always be able to see it. Note that the selection in the TalkingUI and the MainWindow is synchronised in terms of selected users (if a channel is selected, the TalkingUI will not show a selection). This means that this feature plays nicely with the "Whisper to selected" feature (#4048): Select a user in the TalkingUI and you can will use that user as a whisper target if you have your shortcut set to whisper to the currently selected item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Implements #1548
It works by adding a shortcut for the normal
Whisper/Shoutfunctionality but then in the changed UI of selecting the target for that action you'll have to selectCurrent selection