Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GTA V Plugin #4059

Merged
merged 1 commit into from Apr 10, 2020
Merged

Update GTA V Plugin #4059

merged 1 commit into from Apr 10, 2020

Conversation

vimpostor
Copy link
Contributor

Update all memory addresses to the latest build of GTA V (Steam).

Minor other changes:

  • Add the exact build version id to the version description, as Rockstar sometimes updates the GTA binary without even bumping the minor version
  • Remove in_game variable, as state == 2 (being in an online session) already implies in_game == 1

@vimpostor
Copy link
Contributor Author

@davidebeatrici Would you mind compiling this for Windows and uploading the DLL here again?

Unfortunately, I do not have a Windows system available to do it myself.

@davidebeatrici
Copy link
Member

Mumble_GTA_V_Plugin_df14e1ae4ed55eec9692df7cbf8f14bd4ff1e987_MSVC2015.zip

Thank you very much!

in-game was actually not redundant.
I added it because state == 2 also when the game is still loading, if I recall correctly.

@vimpostor
Copy link
Contributor Author

vimpostor commented Apr 9, 2020

in-game was actually not redundant.
I added it because state == 2 also when the game is still loading, if I recall correctly.

Yes, there is a short period of time at the end of the loading screen, where the user still is loading but state == 2. However that is only for a short period of time, GTA seems to already have linked you to the online session and it's just finishing up loading it. The position is also already correctly set to your online spawning point at that time.

There is another advantage though: With the old logic there were 2 noticable disruptions, when entering a building or respawning: There are a few milliseconds, where in_game wasn't set, while your screen goes black. So if you are speaking, the other person hears 2 noticable changes in your voice from going positional to non-positional and back to positional in a very short amount of time.

However, now when you respawn, only the position changes, while audio stays positional during the transition, which is much less disruptive.

@davidebeatrici
Copy link
Member

I agree.

@davidebeatrici
Copy link
Member

@magnus-gross If you confirm it's working fine, I will merge this.

@vimpostor
Copy link
Contributor Author

vimpostor commented Apr 10, 2020

Sure, go ahead.

I just tested how soon state == 2 is set after you start a job from a lobby and it's already set when you are in the vehicle selection screen, but that's probably fair too, as you can see your character in the game world already as well.

I also tested with multiple restarts, and the memory addresses seem to work so I think this is ready to be merged.

@Krzmbrzl Krzmbrzl merged commit 7ed7d95 into mumble-voip:master Apr 10, 2020
@davidebeatrici
Copy link
Member

Thank you again!

@vimpostor vimpostor deleted the gtav branch April 22, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants