Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talking UI #4066

Merged
merged 4 commits into from Apr 30, 2020
Merged

Talking UI #4066

merged 4 commits into from Apr 30, 2020

Conversation

Krzmbrzl
Copy link
Member

@Krzmbrzl Krzmbrzl commented Apr 13, 2020

The TalkingUI is meant as some sort of a light version of the Overlay
primarily intended for use when using the computer normally (e.g. with
many different programs instead of one that is FullScreen).

It consists of a small window that can be toggled and it will show the
names of the person currently talking as well as the channel that person
is in.

If a person has stopped talking for some time (5s in the current
implementation), it will be removed from the UI again.

By default the UI will stay on top of all other windows so that you'll
always be able to see it.

Note that the selection in the TalkingUI and the MainWindow is synchronised in terms of selected users (if a channel is selected, the TalkingUI will not show a selection).
This means that this feature plays nicely with the "Whisper to selected" feature (#4048): Select a user in the TalkingUI and you can will use that user as a whisper target if you have your shortcut set to whisper to the currently selected item.

Mumble_TalkingUI

Changelog

| Added: Talking UI

@Krzmbrzl Krzmbrzl added client feature-request This issue or PR deals with a new feature labels Apr 13, 2020
@Krzmbrzl Krzmbrzl added this to the 1.4.0 milestone Apr 13, 2020
@Krzmbrzl Krzmbrzl force-pushed the feature-talking-UI branch 4 times, most recently from b0ab372 to 8e8f428 Compare April 13, 2020 18:14
src/mumble/TalkingUI.cpp Outdated Show resolved Hide resolved
@Krzmbrzl Krzmbrzl force-pushed the feature-talking-UI branch 4 times, most recently from 6da147e to e1fddb6 Compare April 24, 2020 07:04
…tructor

Right now if an AudioOutputSpeech object gets deleted while not having
finished playing audio, the talking state of the corresponding user will
freeze to be Talking when in fact it should be Passive.

This commit sets the talking state of the corresponding user to Passive
in the destructor to avoid this issue.
The TalkingUI is meant as some sort of a light version of the Overlay
primarily intended for use when using the computer normally (e.g. with
many different programs instead of one that is FullScreen).

It consists of a small window that can be toggled and it will show the
names of the person currently talking as well as the channel that person
is in.

If a person has stopped talking for some time (5s by default but this
interval is configurable via the settings), it will be removed from
the UI again.

By default the UI will stay on top of all other windows so that you'll
always be able to see it.

It is possible to select a user in the TalkingUI. This will lead to the
user being selected in the main ChannelTree as well. The other way
around works as well. If however the user selects a channel in the main
ChannelTree, nothing will be selected in the TalkingUI.
This selection makes it possible to use the TalkingUI in combination
with the "Whisper to selection" feature.
Updating 'mumble_en.ts'...
    Found 1750 source text(s) (6 new and 1744 already existing)
@Krzmbrzl Krzmbrzl merged commit 1bd7839 into mumble-voip:master Apr 30, 2020
@TerryGeng
Copy link
Contributor

This is how it looks in Mac:
image

Personally I'd like to remove this native title bar. What's your opinion :)?

@Krzmbrzl
Copy link
Member Author

Krzmbrzl commented Jun 4, 2020

Personally I'd like to remove this native title bar. What's your opinion :)?

I was also thinking about this, but in that case it can't be easily moved anymore (not everyone knows about Alt+Drag). Same applies for closing it.
Thus I left it in. At least on Linux (KDE Plasma) I can still remove the title bar and window borders if I wish...

@TerryGeng
Copy link
Contributor

TerryGeng commented Jun 4, 2020

Okay... I did some search and found this: https://stackoverflow.com/questions/5513060/qt-4-move-window-without-title-bar

Would this help?
This title bar looks really... ugly IMO so I have an urge to get rid of it :3

@Krzmbrzl
Copy link
Member Author

Krzmbrzl commented Jun 4, 2020

I guess we could do something like this to get rid of the move-problem but the close-problem still remains.

I think the much more annoying part here is that the TalkingUI is actually listed as a separate window in my task bar ^^

@streaps
Copy link

streaps commented Jun 4, 2020

I would prefer to keep the window title bar.

@Krzmbrzl
Copy link
Member Author

Krzmbrzl commented Jun 4, 2020

Ultimately this is a matter of taste. In the end a title bar is the way users expect to be able to interact with such a window though and by removing it we'd probably confuse a lot of users...

Thus I also think we should keep it and anyone who wants to remove it for them, can ask their window manager to do so (if it supports such things) 🤷

@TerryGeng
Copy link
Contributor

TerryGeng commented Jun 4, 2020

Or make it prettier, like Sourcetree,
image

But I guess what would be platform-dependent. Or we have to design a custom UI for it.

Actually I'm quite fond of the original look in the first post of this PR. Is that a custom UI or just how this window looks on some Linux desktop environments?

@Krzmbrzl
Copy link
Member Author

Krzmbrzl commented Jun 4, 2020

Actually I'm quite fond of the original look in the first post of this PR. Is that a custom UI or just how this window looks on some Linux desktop environments?

That's just how it looks on my system (Linux, KDE Neon) with Mumble's light theme

@TerryGeng
Copy link
Contributor

Looks like I need to design my own Mac UI if I want to enjoy mumble on Mac. 🤔️

@Krzmbrzl
Copy link
Member Author

Krzmbrzl commented Jun 4, 2020

Or use Linux :P

@pramadhana92
Copy link

Hi Krzmbrzl, i really like this feature. It helps me so much when there is so many users in one channel.
I try this feature by building mumble on my own, and check the talking ui in configure menu.

I really, really waiting this feature available in official mumble release.
Mumble 1.3.2 has released after this merge request accepted, but why i cannot enable the talking UI from configure menu?

thanks a lot Krzmbrzl!

@davidebeatrici
Copy link
Member

The feature will be part of 1.4.0.

@pramadhana92
Copy link

Thanks for you all effort, i really appreciate it!

@Krzmbrzl
Copy link
Member Author

Thanks for the kind words :)
Good to hear that people are putting this to good use 👍

As Davide pointed out this feature will be part of 1.4.0
The reason why it's not part of 1.3.2 is that only bug and security fixes are backported to older release series. New features will only land with a new release series. IN this case it's 1.4.0 ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants