New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Talking UI #4066
Talking UI #4066
Conversation
b0ab372
to
8e8f428
Compare
1ed91e9
to
2207278
Compare
2207278
to
eb3ff6a
Compare
6da147e
to
e1fddb6
Compare
…tructor Right now if an AudioOutputSpeech object gets deleted while not having finished playing audio, the talking state of the corresponding user will freeze to be Talking when in fact it should be Passive. This commit sets the talking state of the corresponding user to Passive in the destructor to avoid this issue.
e1fddb6
to
013ae4c
Compare
The TalkingUI is meant as some sort of a light version of the Overlay primarily intended for use when using the computer normally (e.g. with many different programs instead of one that is FullScreen). It consists of a small window that can be toggled and it will show the names of the person currently talking as well as the channel that person is in. If a person has stopped talking for some time (5s by default but this interval is configurable via the settings), it will be removed from the UI again. By default the UI will stay on top of all other windows so that you'll always be able to see it. It is possible to select a user in the TalkingUI. This will lead to the user being selected in the main ChannelTree as well. The other way around works as well. If however the user selects a channel in the main ChannelTree, nothing will be selected in the TalkingUI. This selection makes it possible to use the TalkingUI in combination with the "Whisper to selection" feature.
Updating 'mumble_en.ts'... Found 1750 source text(s) (6 new and 1744 already existing)
013ae4c
to
a331e01
Compare
I was also thinking about this, but in that case it can't be easily moved anymore (not everyone knows about Alt+Drag). Same applies for closing it. |
Okay... I did some search and found this: https://stackoverflow.com/questions/5513060/qt-4-move-window-without-title-bar Would this help? |
I guess we could do something like this to get rid of the move-problem but the close-problem still remains. I think the much more annoying part here is that the TalkingUI is actually listed as a separate window in my task bar ^^ |
I would prefer to keep the window title bar. |
Ultimately this is a matter of taste. In the end a title bar is the way users expect to be able to interact with such a window though and by removing it we'd probably confuse a lot of users... Thus I also think we should keep it and anyone who wants to remove it for them, can ask their window manager to do so (if it supports such things) |
That's just how it looks on my system (Linux, KDE Neon) with Mumble's light theme |
Looks like I need to design my own Mac UI if I want to enjoy mumble on Mac. |
Or use Linux :P |
Hi Krzmbrzl, i really like this feature. It helps me so much when there is so many users in one channel. I really, really waiting this feature available in official mumble release. thanks a lot Krzmbrzl! |
The feature will be part of 1.4.0. |
Thanks for you all effort, i really appreciate it! |
Thanks for the kind words :) As Davide pointed out this feature will be part of 1.4.0 |
The TalkingUI is meant as some sort of a light version of the Overlay
primarily intended for use when using the computer normally (e.g. with
many different programs instead of one that is FullScreen).
It consists of a small window that can be toggled and it will show the
names of the person currently talking as well as the channel that person
is in.
If a person has stopped talking for some time (5s in the current
implementation), it will be removed from the UI again.
By default the UI will stay on top of all other windows so that you'll
always be able to see it.
Note that the selection in the TalkingUI and the MainWindow is synchronised in terms of selected users (if a channel is selected, the TalkingUI will not show a selection).
This means that this feature plays nicely with the "Whisper to selected" feature (#4048): Select a user in the TalkingUI and you can will use that user as a whisper target if you have your shortcut set to whisper to the currently selected item.
Changelog