Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer: Do not delete murmur.ini #4096

Merged
merged 1 commit into from Apr 22, 2020
Merged

Installer: Do not delete murmur.ini #4096

merged 1 commit into from Apr 22, 2020

Conversation

trudnorx
Copy link
Contributor

Fixes #4090.

Krzmbrzl
Krzmbrzl requested changes Apr 22, 2020
View changes
Copy link
Member

@Krzmbrzl Krzmbrzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix your commit message with Installer: like so:

Installer: Make uninstaller not delete murmur.ini

Btw the Mac-CI just had some weird issues it has from time to time. It's not related to your changes :)

@trudnorx trudnorx changed the title Make uninstaller not delete murmur.ini Installer: Do not delete murmur.ini Apr 22, 2020
@trudnorx
Copy link
Contributor Author

@Krzmbrzl Can you do it? I don't have Git setup rn, I was using the web interface which doesn't allow that.

@Krzmbrzl
Copy link
Member

Done :)

@trudnorx
Copy link
Contributor Author

@Krzmbrzl thanks :)

@trudnorx
Copy link
Contributor Author

@Krzmbrzl merge?

@Krzmbrzl Krzmbrzl merged commit c1359c9 into mumble-voip:master Apr 22, 2020
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Apr 22, 2020 •
edited

merge?

Yes - Just wanted the CI to finish and I went on a walk in the meantime :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krzmbrzl Krzmbrzl Krzmbrzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows uninstaller deletes murmur.ini
2 participants
@trudnorx @Krzmbrzl